[Feature] Add credential provider for Azure Github OIDC #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
approved these changes
Jul 11, 2024
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/OidcTokenSource.java
Show resolved
Hide resolved
...sdk-java/src/main/java/com/databricks/sdk/core/oauth/AzureGithubOidcCredentialsProvider.java
Show resolved
Hide resolved
…abricks-sdk-java into rh/github-oidc-azure-auth
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
## 0.27.1 ### New Features and Improvements * Specify proxy auth explicitly when using system proxy ([#300](#300)). * Accept any `HttpRequest` instead of `HttpUriRequest` in `CommonHttpClient` ([#305](#305)). * Add credential provider for Azure Github OIDC ([#307](#307)). ### Internal Changes * Add Release tag and Workflow Fix ([#309](#309)). * Improve Changelog by grouping changes ([#308](#308)). * Test parsing of error messages with `int` error codes ([#303](#303)). * Run AccountClientIT test only for aws-prod-ucacct ([#311](#311)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a
CredentialsProviderto authenticate with Azure from a Github action using OIDC. The implementation echoes the one in the Go and Python SDKs.Tests
Most of the new code paths are covered by the test. Note that I'm adding the
org.jsonlibrary to help building JSON object in a concise way. The library is fairly mature and part of the Android SDK.