Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable default layout #248

Merged
merged 13 commits into from
Oct 29, 2022
Merged

Configurable default layout #248

merged 13 commits into from
Oct 29, 2022

Conversation

ian-r-rose
Copy link
Collaborator

Fixes #247
dask-layout

@quasiben
Copy link
Member

Very cool!

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very cool indeed. @ian-r-rose I'm wondering how can folks make/integrate their own custom layout?

@ian-r-rose
Copy link
Collaborator Author

Ah, very cool indeed. @ian-r-rose I'm wondering how can folks make/integrate their own custom layout?

It still needs documentation, but briefly, you can refer to the names of the individual-* plots, and specify how they are going to be put into the main area. So the default looks like this:

        "individual-task-stream": {
          "mode": "split-right",
          "ref": null
        },
        "individual-workers-memory": {
          "mode": "split-bottom",
          "ref": "individual-task-stream"
        },
        "individual-progress": {
          "mode": "split-right",
          "ref": "individual-workers-memory"
        }

Which puts the task stream chart on the right, then puts the worker memory chart beneath the task stream chart, then puts the progress chart to the right of the worker memory chart.

You can't make an arbitrary layout, since you can't refer to other things like notebooks and terminals, but you can make a little "dask" zone however you like.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@ian-r-rose
Copy link
Collaborator Author

I should also note that JupyterLab has recently grown a nice new settings UI that can read json schema, and it works reasonably well for this new configuration object:

image

@ian-r-rose ian-r-rose self-assigned this Oct 27, 2022
@ian-r-rose
Copy link
Collaborator Author

Also experimenting with a new interaction where the Client repr gets a button which automatically populates the dashboard URL and then launches the default layout:
dask-layout-2

The goal being to drastically reduce the number of clicks to get your dashboards setup next to your notebooks.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ian-r-rose! I think it would be nice to add some documentation on how users can add there own layouts, but overall I think you should merge this whenever you're happy with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default layout
4 participants