Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include button for launching jupyterlab layout in repr #7218

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

ian-r-rose
Copy link
Collaborator

@ian-r-rose ian-r-rose commented Oct 28, 2022

This is an experimental UI element to help ease dashboard setup in a JupyterLab environment. Doesn't make sense to merge without a paired release of dask-labextension, but opening for discussion/visibility.

dask-layout-2

Edit: this is now ready for review, and works with dask-labextension==6.0.0.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  +       15         15 suites  +15   6h 34m 14s ⏱️ + 6h 34m 14s
  3 169 tests +  3 169    3 084 ✔️ +  3 084    83 💤 +  83  2 +2 
23 448 runs  +23 448  22 544 ✔️ +22 544  900 💤 +900  4 +4 

For more details on these failures, see this check.

Results for commit 87e2dfe. ± Comparison against base commit a605d61.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@gjoseph92 gjoseph92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this!

@mrocklin mrocklin merged commit 17156e9 into dask:main Nov 6, 2022
@mrocklin
Copy link
Member

mrocklin commented Nov 6, 2022

It looks like dask-labextension 6.0.0 is out. The CI failures are unrelated. Merging this in. Thank you @ian-r-rose

@mrocklin
Copy link
Member

mrocklin commented Nov 6, 2022

Question though: I often run JupyterLab in my base environment and then run Dask in a separate conda environment. In this case our code won't have dask-labextension in the same space. Correct? I think that this solution only works if I'm running Dask in the same environment where JLab is running. Correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants