Fix BULLET_INCLUDE_DIRS in DARTConfig.cmake #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix from #361 doesn't work if bullet packages was failed to be found by `find_package()`. When bullet is not found, `BULLET_INCLUDE_DIRS` will be set to `BULLET_INCLUDE_DIRS-NOT-FOUND` rather than blank as we assumed in #361. Instead, we set `DART_INCLUDE_DIRS` in the top level CMakeList.txt by adding `BULLET_INCLUDE_DIRS` to `DART_INCLUDE_DIRS` only when bullet is found. `DARTConfig.cmake` is then configured using `DART_INCLUDE_DIRS`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix from #361 doesn't work if bullet package was failed to be found by
find_package(). When bullet is not found,BULLET_INCLUDE_DIRSwill be set toBULLET_INCLUDE_DIRS-NOT-FOUNDrather than blank as we assumed in #361.Instead, we set
DART_INCLUDE_DIRSin the top level CMakeList.txt by addingBULLET_INCLUDE_DIRStoDART_INCLUDE_DIRSonly when bullet is found.DARTConfig.cmakeis then configured usingDART_INCLUDE_DIRS.This change is