-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSK file parser #561
VSK file parser #561
Conversation
- The attribute getters are defined for different types - ElementEnumerator is templated to cover const and non-const elements - The element value getters are changed to takes const element pointer
- Remove initMeshes() since it's not used anywhere - Rename updateVolume() to computeVolume() to match the naming convention - Add static methods computing volume and moments of inertia for shape whoes volume is not zero
Tested on my data, and looks good to me. |
# Resolved conflicts: # dart/dynamics/BoxShape.cpp # dart/dynamics/EllipsoidShape.cpp # dart/dynamics/MeshShape.cpp
I believe this pull request is ready to merge. @mxgrey any comments? |
I'll finish reviewing it tonight. One thought that comes to mind is that the Marker class should probably be refactored into a Node once PR #531 is finished. |
@mxgrey: Agreed. It seems like much of what the |
Agreed to the idea. |
Since |
I've finished looking through the pull request, and it generally looks good to me. I just think we should either change |
Updated this PR responding the comments. Will merge this PR once CI's are happy. |
This pull request reinstates VSK parser that was obsoleted since DART 3.0.
The VSK file format, which is developed by Vicon Motion Systems, contains skeleton hierarchy and markers. The specifications of VSK structure can be found here. Note that the VSK file format lacks some information to build dynamic skeleton models such as body node's shape, mass, and inertia. The missing information can be provided through
Options
parameter to the parser.Also,
Parser.[h/cpp]
files are renamed to more relevant nameXmlHelpers.[h/cpp]
with some improvements on parsing xml attributes.