Conditional build depending on missing symbols of Assimp package #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DART now is able to detect if installed Assimp is missing C++ symbols so we don't need to restrict DART to depend on the version of Assimp that is missing the symbols.
|
👍 Good idea! This is much nicer than the versioned dependency I added in #455. |
|
Very clever use of cmake. Looks good to me 👍 |
|
Yeah, it's very useful feature of cmake. Thanks! |
jslee02
added a commit
that referenced
this pull request
Nov 5, 2015
Conditional build depending on missing symbols of Assimp package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debian packages of Assimp in Ubuntu is missing C++ symbols so DART has our own implementation of them, and we made DART depend on the version of Assimp that is missing symbols by #455. However, it can be problematic when DART is built with Assimp version that contains the missing symbols.
This pull request enables DART to detect whether the installed Assimp has the missing symbols or not in cmake time, and compile our own implementation of them only when they are missing in the Assimp.