Require Assimp < 3.0~dfsg-4 #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have not discussed about the next release schedule yet but I'm thinking to release DART 5.0.1 around Aug 3 that would just include patches. If you want to ship this change in DART 5.0.1, please change the target branch to Note that all the patches of DART 5.0.1 will be applied to the next version of DART as well by merging Beside the target branch 👍 |
|
Yes, that makes sense. This should be included in 5.0.1. I will make a new pull request against that target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes DART depend on the version of Assimp that is missing C++ symbols; see #451 for details. This should stop DART from breaking when Assimp
3.0~dfsg-4is released on Ubuntu. It would be good if @jslee02 could release a new version of DART with this change to stave off any potential problems.Next, I will build the Debian packages for the updated version of Assimp and work with @jslee02 to get them in the DART PPA. Once that is done, we can modify the
debian/controlfile to depend onlibassimp-dev (>= 3.0~dfsg-4)and release a version of DART without the customaiScenemethods.