Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fclConfig.cmake #1640

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Use fclConfig.cmake #1640

merged 1 commit into from
Dec 24, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 24, 2021

resolves #736

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 24, 2021
@jslee02 jslee02 merged commit 261e28c into main Dec 24, 2021
@jslee02 jslee02 deleted the fcl_config branch December 24, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.13.0
Development

Successfully merging this pull request may close these issues.

Use fclConfig.cmake once FCL 0.5 becomes minimum requirement
1 participant
@jslee02