Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Changing macos version to macos-10.12 in workflows #985

Closed
wants to merge 1 commit into from

Conversation

pravinpushkar
Copy link
Contributor

@pravinpushkar pravinpushkar commented May 23, 2022

Signed-off-by: Pravin Pushkar ppushkar@microsoft.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #981

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar requested review from a team as code owners May 23, 2022 07:10
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #985 (0bc939c) into master (0c51481) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   21.71%   21.71%           
=======================================
  Files          33       33           
  Lines        1920     1920           
=======================================
  Hits          417      417           
  Misses       1449     1449           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c51481...0bc939c. Read the comment docs.

@pravinpushkar
Copy link
Contributor Author

closing this for now, as macos related workflow is not even starting. I will be testing this in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow for E2E - self hosted is not stable on MacOS - darwin
1 participant