Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderBy? Any plans to Implement? #20

Closed
BallisticPain opened this issue Jan 27, 2017 · 5 comments
Closed

OrderBy? Any plans to Implement? #20

BallisticPain opened this issue Jan 27, 2017 · 5 comments

Comments

@BallisticPain
Copy link

So I just stumbled across your library of pipes and it seems quite extensive and you seem to provide updates quite often. I wanted to reach out and see if you've considered an orderBy pipe, and if you have it already please forgive me for not recognizing it.

Thoughts?

@BallisticPain
Copy link
Author

@danrevah
Copy link
Owner

danrevah commented Jan 28, 2017

Looks like a good idea for a new pipe.
I will definitely add this one in the following days.

Thanks.

danrevah added a commit that referenced this issue Jan 28, 2017
danrevah added a commit that referenced this issue Jan 28, 2017
danrevah added a commit that referenced this issue Jan 28, 2017
@danrevah
Copy link
Owner

danrevah commented Jan 28, 2017

There's a draft version under the next branch:

API: https://github.com/danrevah/ngx-pipes/tree/next#orderby
Code: https://github.com/danrevah/ngx-pipes/blob/next/src/app/pipes/array/order-by.ts

This will be merged in the following days into master & released on the next version.
Left todo:

  • Performance test
  • Refactor a cleaner version

danrevah added a commit that referenced this issue Jan 28, 2017
danrevah added a commit that referenced this issue Jan 29, 2017
@danrevah
Copy link
Owner

danrevah commented Jan 29, 2017

Merged into master and released to version v1.3.1
https://github.com/danrevah/ngx-pipes#orderby

Thanks.

@BallisticPain
Copy link
Author

Fantastic work and quickly done... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants