feat(#20): orderBy fully coverage

danrevah · Jan 28, 2017 · c69f731 · c69f731
1 parent d09cacc
commit c69f731
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/app/pipes/array/order-by.ts b/src/app/pipes/array/order-by.ts
@@ -12,7 +12,6 @@ export class OrderByPipe implements PipeTransform {
     const out = [...arr];
 
     if (Array.isArray(config)) {
-
       return out.sort((a, b) => {
         let pos;
 
@@ -38,7 +37,17 @@ export class OrderByPipe implements PipeTransform {
       return out.sort(OrderByPipe.orderCompare.bind(this, prop, asc));
     }
 
-    return out.sort();
+    return out.sort((a, b) => {
+      if (GeneralHelper.isString(a) && GeneralHelper.isString(b)) {
+        return a.toLowerCase().localeCompare(b.toLowerCase());
+      }
+
+      if (a === b) {
+        return 0;
+      }
+
+      return a < b ? -1 : 1;
+    });
   }
 
   static orderCompare(prop, asc, a, b) {