Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated qmake build system / removed Qt5 fallback when using USE_QT6=On #5271

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jul 27, 2023

QT 5 is now completely EOL and since we never supported Qt6 in qmake which also has various shortcomings, it is time to at least deprecate it and direct users to CMake instead.

Extracted from #4957.

@firewave
Copy link
Collaborator Author

apt.llvm.org repository is currently broken - see llvm/llvm-project#64120 (comment).

@danmar
Copy link
Owner

danmar commented Aug 7, 2023

hmm.. I have problems with cmake.

I am working on a windows docker container that has the cppcheck build tools (visual studio, qt, wix, cmake). This container will make it possible to reproduce release builds. I do not mind to publish the container... I will do it asap..

@firewave
Copy link
Collaborator Author

firewave commented Aug 7, 2023

Visual Studio includes CMake support: https://learn.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio

Also if you use qmake you always need at least one other build system to be the remaining parts (like testrunner) of the project. It is also lacking several options which are only available in CMake. Also we would need to do all changes we do in qmake also in CMake so it makes sense to get rid of the less complete one. That would also require less steps in the CI.

This is also only deprecating it with no deadline. Qt6 still needs a bit of work in several parts of the CI which is what #4957 is about.

With Qt5 being EOL and phased out and no support for it in qmake on our side people need to switch anyways. Also the Qt5/qmake build is not working on several older Linux systems so you had to use CMake anyways. So this is just underlining this.

@firewave
Copy link
Collaborator Author

firewave commented Aug 8, 2023

Also if you use qmake you always need at least one other build system to be the remaining parts (like testrunner) of the project.

You also build lib twice in that case as I just realized while looking at the Windows release job.

@danmar
Copy link
Owner

danmar commented Aug 9, 2023

hmm.. I have problems with cmake.

I did not manage to reproduce those problems today. It seems CMake is working for me in my windows container. Well feel free to deprecate qmake.

@firewave
Copy link
Collaborator Author

firewave commented Aug 9, 2023

I did not manage to reproduce those problems today. It seems CMake is working for me in my windows container. Well feel free to deprecate qmake.

Please file a ticket and put me in cc if you ever encounter it again.

@firewave firewave merged commit de9795b into danmar:main Aug 9, 2023
@firewave firewave deleted the qmake-depr branch August 9, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants