fixed #12042 - deprecated building with Qt5 / build with Qt6 in CI / updated latest Qt in CI to 6.5.3 #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the CI files so this does not trigger a build to ease things. So please review the individual commits as the CI changes are not visible. |
qmake build system / removed fallback when using USE_QT6=On / build with Qt6 in CIqmake build system and Qt5 / removed fallback when using USE_QT6=On / build with Qt6 in CI
|
Using Qt6 seems to switch the whole project to C++17 leading to unexpected clang-tidy warnings and the runtime of the clang-tidy step seems to be balloon because of it. Also there seems to be no Qt6 on ubuntu 20.04 so deprecating Qt5 should be fine but dropping it (even though EOL) doesn't seem like an option in the near future. |
qmake build system and Qt5 / removed fallback when using USE_QT6=On / build with Qt6 in CI17c1e25 to
e0c7846
Compare
fdc5285 to
4434ad3
Compare
This was referenced Oct 16, 2023
… also avoids `-Wctad-maybe-unsupported` Clang compiler warnings with Qt6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt 5.15 will be EOL on May 26 so we should start switching away from it. We already have issues with many of the previous versions and qmake on legacy distros so we should cut that off.
I will add a Qt6 release build for Windows in another PR so it can be tested. We should switch to it as the delivered build after the next release and stop using Qt5 altogether in the CI in the release afterwards (that would get rid of several build steps). We could leave it so you could still try to build it but no longer support it so it is up to the user to get it to work before removing it completely later on.