Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android support #97

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Add android support #97

merged 1 commit into from
Dec 21, 2019

Conversation

esdmr
Copy link
Contributor

@esdmr esdmr commented Jun 2, 2019

Many android devices do not have any terminal emulator pre-installed, but they have the /system/bin/ping and /system/bin/ping6 binaries.
I have runned the tests on termux and all of them succeeded.

@mondwan
Copy link
Collaborator

mondwan commented Jun 7, 2019

hi @esdmr , thanks for your contribution. As there is some critical changes described on #94, I will look after this MR after settling changes there. Thanks

@esdmr
Copy link
Contributor Author

esdmr commented Dec 17, 2019

As PR #94 was merged, I have rebased (and removed unnecessary conditions) from this PR. It is ready to be reviewed.

@mondwan
Copy link
Collaborator

mondwan commented Dec 21, 2019

Thanks @esdmr

@mondwan mondwan merged commit bf95ccd into danielzzz:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants