Parse IPv6 host & numeric host on Linux #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we have a config for |
|
@mondwan Not unless the v6 flag actually works across the board. Related to: #95 & #79 (comment) |
added 2 commits
June 7, 2019 18:15
As discribed at #95, ping / ping6 may be installed in other system path in linux system. Therefore, we decided to rely on `shell` option instead of hard coding the executable path
|
@texh Please check whether the implementation works on your platform or not. I will merge this MR soon if there are no more feedback. Thanks |
Merged
|
@mondwan At a glance it looks like it should do the business - will try it out in a few hours and report back 😄 |
|
It sounds there are no problem. I will merge it soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #79
Not sure if I've gone about this the right way, but the odd spacing and bracket placement in Linux with
ping6meant that 'numeric_host' was never getting set. In a project I'm working on I get odd values for 'host' likeone.one.one.one(2606:4700:4700::1111)I wasn't sure how to deal with responses like the following two where the ping command only gives you an IP address or a hostname and not both. In those cases
hostandnumeric_hostwill be the same, ie:I'm tempted to sit on this PR a while and wait for suggestions, as well as try to find a few more machines that I can grab test fixtures from to make sure it does what it should.
Edit: Oh yeah! https://travis-ci.org/texh/node-ping. Node >=4 are all passing, lower versions bail on an error with grunt using too-modern JS.