Bugs with focusedNodeId #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be merging this one. Thanks for following up on this @TranquilMarmot. I've created a follow-up issue to tackle those bugs you've mentioned: #415 |
danielcaldas
approved these changes
Dec 18, 2020
TranquilMarmot
added a commit
to TranquilMarmot/YarnLoom
that referenced
this pull request
Feb 6, 2021
Notable upgrades: - `react-d3-graph`: `1.5.0` ➡️ `1.6.0` - This includes some potential fixes for dragging the viewport after focusing on a node (danielcaldas/react-d3-graph#374) - `react-scripts` (Create React App): `3.4.1` ➡️ `4.0.1` - Move from `@emotion/core` `10.0.28` ➡️ `@emotion/react` `11.1.4` - This now requires using [Babel macros](https://emotion.sh/docs/babel-macros) - This also required changing `/** @jsx jsx */` to `/** @jsxImportSource @emotion/react */` 🤮 - `typescript`: `3.9.6` ➡️ `4.1.3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #341 which seems to have been abandoned.
Some bugs I don't know how to fix...
onZoomChangeprop isn't properly called when zooming in on focused node.on('end', _zoomEnd)in_zoomConfigbut that zoom function isn't called at all when focusing on a node idUNSAFE_componentWillReceivePropscaused an infinite loop and a crashfocusedNodeIdcan have unpredictable results; sometimes it will "jump" around and sometimes it won't