You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
This is a follow up to #374 and #341. Although some of the bugs concerning the animated zoom capabilities were addressed, there are still a few gaps that need to be addressed, although with lower priority.
To Reproduce
onZoomChange prop isn't properly called when zooming in on focused node
I tried to add this in .on('end', _zoomEnd) in _zoomConfig but that zoom function isn't called at all when focusing on a node id
Putting it in UNSAFE_componentWillReceiveProps caused an infinite loop and a crash
Trying to zoom (with the mouse wheel) while a node is focused causes a weird "jump" in the zoom level (the focused node zoom seems to take precedence but only after an update)
Trying to pan while there's a focusedNodeId can have unpredictable results; sometimes it will "jump" around and sometimes it won't
Describe the bug
This is a follow up to #374 and #341. Although some of the bugs concerning the animated zoom capabilities were addressed, there are still a few gaps that need to be addressed, although with lower priority.
To Reproduce
I tried to add this in .on('end', _zoomEnd) in _zoomConfig but that zoom function isn't called at all when focusing on a node id
Thanks, @TranquilMarmot for the details.
Expected behavior
The above-described bugs should go away.
Environment:
Additional context
For additional context check the first PR #341
The text was updated successfully, but these errors were encountered: