Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the focusedNodeId capability #415

Open
danielcaldas opened this issue Dec 18, 2020 · 0 comments
Open

Issues with the focusedNodeId capability #415

danielcaldas opened this issue Dec 18, 2020 · 0 comments

Comments

@danielcaldas
Copy link
Owner

Describe the bug
This is a follow up to #374 and #341. Although some of the bugs concerning the animated zoom capabilities were addressed, there are still a few gaps that need to be addressed, although with lower priority.

To Reproduce

  • onZoomChange prop isn't properly called when zooming in on focused node
    I tried to add this in .on('end', _zoomEnd) in _zoomConfig but that zoom function isn't called at all when focusing on a node id
    • Putting it in UNSAFE_componentWillReceiveProps caused an infinite loop and a crash
  • Trying to zoom (with the mouse wheel) while a node is focused causes a weird "jump" in the zoom level (the focused node zoom seems to take precedence but only after an update)
  • Trying to pan while there's a focusedNodeId can have unpredictable results; sometimes it will "jump" around and sometimes it won't

Thanks, @TranquilMarmot for the details.

Expected behavior
The above-described bugs should go away.

Environment:

  • OS: All
  • Browser: All
  • react-d3-graph version: >=2.5.0
  • d3 version: not relevant
  • react version: not relevant

Additional context
For additional context check the first PR #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant