-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding unicode values in the config object passed to the browser #5451
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this fixes the original issues bug with the あいうえお
characters.
I didn't review the code specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, didn't know that atob didn't work with Unicode. Nice fix, LGTM
runner
config object so it can't b… #5155User-facing changes
Environment variables with unicode values are correctly passed to the runner again. In 3.5.0 we have accidentally broken them by encoding resolved Cypress config object incorrectly. This became a problem for anyone using Unicode characters in their environment variables in the configuration file like
PR Tasks