Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base64 encode the embedded runner config object so it can't b… #5155

Merged
merged 3 commits into from
Sep 17, 2019
Merged

base64 encode the embedded runner config object so it can't b… #5155

merged 3 commits into from
Sep 17, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Sep 17, 2019 •
edited
Loading

Pre-merge Tasks

  • Have tests been added/updated for the changes in this PR?
  • Has the original issue been tagged with a release in ZenHub?

@flotwig flotwig mentioned this pull request Sep 17, 2019
Closed
@flotwig flotwig changed the title base64 encode the embedded runner config object so it can't be broken by user input [WIP] base64 encode the embedded runner config object so it can't be broken by user input Sep 17, 2019
@cypress
Copy link

cypress bot commented Sep 17, 2019 •
edited
Loading


Test summary

3337 • 0 • 47 • 0

Run details
Project cypress
Status Passed
Commit 10f6e8d
Started Sep 17, 2019 5:58 PM
Ended Sep 17, 2019 6:03 PM
Duration 04:42 💡
OS Linux Debian - 8.10
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title [WIP] base64 encode the embedded runner config object so it can't be broken by user input base64 encode the embedded runner config object so it can't be broken by user input Sep 17, 2019
chrisbreiding
chrisbreiding approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flotwig flotwig changed the title base64 encode the embedded runner config object so it can't be broken by user input base64 encode the embedded runner config object so it can't b… Sep 17, 2019
@flotwig flotwig merged commit 8cde36e into develop Sep 17, 2019
@flotwig flotwig deleted the issue-4952 branch September 17, 2019 19:51
@flotwig flotwig restored the issue-4952 branch September 18, 2019 16:07
grabartley pushed a commit to grabartley/cypress that referenced this pull request Oct 6, 2019
@flotwig @grabartley
base64 encode the embedded runner config object so it can't b… (cyp…
2e240a7 
…ress-io#5155)

* base64 encode the config so it can't be escaped

* update tests
This was referenced Oct 24, 2019
Closed
Merged
@semantic-commit semantic-commit bot mentioned this pull request Nov 21, 2019
Closed
@flotwig flotwig deleted the issue-4952 branch January 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbreiding chrisbreiding chrisbreiding approved these changes

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cypress.env() fails to escape <script></script> tags in the cypress.json file
2 participants
@flotwig @chrisbreiding