Clean env variable CYPRESS_INSTALL_BINARY before checking #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // so for sanity sake we should first trim whitespace characters and remove | ||
| // double quotes around environment strings if the caller is expected to | ||
| // use this environment string as a file path | ||
| return trim ? dequote(_.trim(result)) : result |
There was a problem hiding this comment.
Does it remove the quotes first or trim first? Does an example like "foo.txt " work properly in your test?
There was a problem hiding this comment.
first trims the whitespace, then removes quotes, and there are unit tests, let me add one specifically for your case
jennifer-shehane
approved these changes
Jul 3, 2019
kuceb
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CYPRESS_INSTALL_BINARYsee Windows difficulties Cypress not installing using local zip on windows #4506 (comment)