-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress not installing using local zip on windows #4506
Comments
as described in https://on.cypress.io/installing-cypress#Run-binary You cannot set it to a zipped file. |
I'm talking about
https://docs.cypress.io/guides/getting-started/installing-cypress.html#Install-binary |
So sorry for misreading. Do you have a |
I have not, I'll try in a bit and report back. But that doesn't take away from the fact that installing using from a local zip is not working. Judging from the documentation and the example provided there this might have something to do with Windows specifically. For now, I can still get by running 3.2.0 which I was able to install via the method described earlier. |
It doesn't throw the self-signed certificate error anymore 🎉 It would still be a good idea to make sure the local install works since downloading Cypress is not a great experience in itself. At the moment it's stuck at 39%, but that's a separate issue. |
@Lakitna can I ask you to run
so we can see what it does there on Windows? |
@bahmutov I've run it and pasted it in a Gist https://gist.github.com/Lakitna/91d6a34586558cceab4d4f8972e10b8a |
Great, @Lakitna I see
What happens when you set the zip using the Windows backslashes? Is there escaping going on? I think it better be quoted too
|
I've tried the following ways of linking to the install binary:
|
hmm, interesting, here is the relevant file check debug('checking local file', possibleFile, 'cwd', process.cwd())
return fs.pathExistsAsync(possibleFile)
.then((exists) => {
// if this exists return the path to it
// else false
if (exists && path.extname(possibleFile) === '.zip') {
return possibleFile
}
return false
}) For some reason it does not think the local file exists when checking
and before that if the filename is quoted, it is concatenated to be
very weird |
That is so weird I had to see it for myself. > const fs = require('fs-extra');
> fs.pathExists('C:\absolute\path\to\existing\file.txt').then((result) => console.log(result));
false
> fs.pathExists('C:/absolute/path/to/existing/file.txt').then((result) => console.log(result));
true I guess normalizing the path to |
another thing that really bothers me here is our version of |
Note that I used |
I am currently in the process of updating |
@Lakitna you are not escaping the backslashes in the first case, it should be const fs = require('fs-extra');
fs.pathExists('C:\\absolute\\path\\to\\existing\\file.txt') I have tested it on Windows and it is reporting the right thing, see https://github.com/cypress-io/file-check-win BUT: look at the experiments on Windows in https://ci.appveyor.com/project/cypress-io/file-check-win/history
Here YAML file that just calls a program passing
|
@bahmutov Whoops, forgetting to escape is a rookie mistake in Windows. When is Windows going to use Here, have another wtf:
Can you trim edit: For the sake of clarity. The following both work in
|
yeah, this is what I want to do in #4579 |
The code for this is done in cypress-io/cypress#4579, but has yet to be released. |
Released in |
Current behavior:
When running the following command
Where
C:/temp/cypress.zip
is a fresh download of 3.3.1.The installation gets aborted because it seems like it tries to use the path as a relative external url.
Note the URL.
I've tried all kinds of ways of providing the url
\
\\
/
file://C:/temp/cypress.zip
http://C:/temp/cypress.zip
(it doesn't make sense, but I got desperate)It fails on the self-signed certificate because of the corporate proxy.
Desired behavior:
Able to install from a local zip as described here https://docs.cypress.io/guides/getting-started/installing-cypress.html#Install-binary
Steps to reproduce: (app code and test code)
Versions
Trying to install Cypress 3.3.1
Windows 10
Behind a corporate proxy and all the corporate goodies it brings with it
The text was updated successfully, but these errors were encountered: