chore: do NOT encode backslash as this will cause pathing issues on windows #31020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
approved these changes
Feb 4, 2025
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/fix_priv_channel_windows
|
| Run status |
|
| Run duration | 12m 56s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
222
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
64.37%
|
|
|---|---|
|
Untested elements
|
29
|
|
Tested elements
|
56
|
Accessibility
96.18%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
198
|
mschile
reviewed
Feb 4, 2025
41fb394 to
67f1627
Compare
mschile
approved these changes
Feb 4, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Caught an issue with #31001 where
encodeURIdoes NOT encode forward slashes, but does encode backslashes. We do not want to encode backslashes, especially on Windows as this will not match the path in the stacktrace and always fail task commands, which would be very bad.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?