fix: make sure privileged commands can run when there is a space in the spec or support file name #31001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he spec or support file name
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/priv_command_channel
|
| Run status |
|
| Run duration | 17m 25s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
9
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26542
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.43%
|
|
|---|---|
|
Untested elements
|
192
|
|
Tested elements
|
164
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
888
|
mschile
approved these changes
Jan 31, 2025
jennifer-shehane
approved these changes
Feb 1, 2025
cli/CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ _Released 2/11/2025 (PENDING)_ | |||
| **Bugfixes:** | |||
|
|
|||
| - All commands performed in `after` and `afterEach` hooks will now correctly retry when a test fails. Commands that are actions like `.click()` and `.type()` will now perform the action in this situation also. Fixes [#2831](https://github.com/cypress-io/cypress/issues/2831). | |||
| - Privileged commands will now run correctly when a spec file or support file contains characters that require encoding. Fixes [#30933](https://github.com/cypress-io/cypress/issues/30933). | |||
There was a problem hiding this comment.
@AtofStryker Can you note that this is fixing a regression in 14.0.0?
3 tasks
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With the release of Cypress 14, some of the logic around stack lines and traces changed. One thing we forgot to check for when matching script to stack traces lines is whether both strings are encoded the same way. The stack trace URLs are URI encoded, but the script files are not. This means that if there is a space or unicode character in the file name we will not be able to correctly match the command invocation destination, which throws the error.
Before fix
After fix
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?