fix: transition eventManager errors

[marktnoonan]

Two small fixes:

1. Wrapper div in Runner.vue so there is a HTML root element for the transition. Navigation to other pages from Spec Runner works normally now.
2. Testing navigating from a spec, to the rest of the app, and then to another spec, I saw an event manager error and the new spec would not load. On the 2nd visit to the Spec Runner, we were trying to get the eventManager before it was initialized. Resetting the value of the initialized ref when we unmount the runner component fixes that, because the container component uses v-if="initialized" to decide when to render the runner itself, so if it stays true, we render too early on subsequent visits.

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

4351 • 0 • 51 • 0 • 0

---

Run details

Project	cypress
Status	Passed
Commit	d8b1e97
Started	Jan 24, 2022 2:12 AM
Ended	Jan 24, 2022 2:25 AM
Duration	13:12 💡
OS	Linux Debian - 10.10
Browser	Electron 94

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[brian-mann]

cc @lmiller1990 as this sounds related to work we did previously together regarding initialization and memoizing initialization of the runner code

[lmiller1990]

Yep, seems like a good place to do this

[lmiller1990]

I wonder if we can add a basic test of sorts, eg - navigate to the runner, choose a spec, navigate away? IIRC that was breaking when we tried last week, and since this fixes that problem, we could also add a test for it (I think we have the infrastructure to facilitate this kind of test now)?

[brian-mann]

Yes, we have the infra now. I wouldn’t have merged this PR without tests. Please add them. No PRs should be going in without tests. That’s just asking for regressions to trip us up later.

[marktnoonan]

Yes, just checked and with the new Cypress in Cypress, we can visit the spec, then go to Settings or Runs and go back to the Specs List and click in to see the spec again. Seems like there is a lot of great stuff we'll be able to do with this! I'll make a PR with the new tests shortly.