fix: transition eventManager errors (#19835)

* add wrapper div for transition * clean up `initialized` value when unmounting * formatting
cypress-io · Jan 24, 2022 · 5cac74c · 5cac74c · cypress-bot · Jan 24, 2022
1 parent 096c4eb
commit 5cac74c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 21 deletions.
diff --git a/packages/app/src/pages/Specs/Runner.vue b/packages/app/src/pages/Specs/Runner.vue
@@ -1,25 +1,27 @@
 <template>
-  <!--
-    Run Mode is a more minimal UI.
-    It does not render things like the SpecList,
-    Side and Top Nav, etc.
-    It also has no GraphQL dependency.
-  -->
-  <SpecRunnerContainerRunMode
-    v-if="isRunMode"
-    :run-mode-specs="specs"
-  />
-
-  <!--
-    Open Mode is the full Cypress runner UI -
-    including things like the SpecList,
-    Side and Top Nav, Selector Playgroundn etc.
-    It is driven by GraphQL and urql.
-  -->
-  <SpecRunnerContainerOpenMode
-    v-else-if="query.data.value?.currentProject?.specs"
-    :gql="query.data.value"
-  />
+  <div>
+    <!--
+      Run Mode is a more minimal UI.
+      It does not render things like the SpecList,
+      Side and Top Nav, etc.
+      It also has no GraphQL dependency.
+    -->
+    <SpecRunnerContainerRunMode
+      v-if="isRunMode"
+      :run-mode-specs="specs"
+    />
+
+    <!--
+      Open Mode is the full Cypress runner UI -
+      including things like the SpecList,
+      Side and Top Nav, Selector Playgroundn etc.
+      It is driven by GraphQL and urql.
+    -->
+    <SpecRunnerContainerOpenMode
+      v-else-if="query.data.value?.currentProject?.specs"
+      :gql="query.data.value"
+    />
+  </div>
 </template>
 
 <script lang="ts" setup>

diff --git a/packages/app/src/runner/unifiedRunner.ts b/packages/app/src/runner/unifiedRunner.ts
@@ -15,6 +15,7 @@ export function useUnifiedRunner () {
 
   onBeforeUnmount(() => {
     UnifiedRunnerAPI.teardown()
+    initialized.value = false
   })
 
   return {