Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "fix(deps): update dependency electron to v13 🌟 (#17037)" #17372

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 16, 2021

This reverts commit bda59dd.

  • Closes

User facing changelog

n/a - unreleased

Additional details

Reverts #17037.

Since we are not sure if #16152 will continue to affect Electron 13.x, we are going to stick with the downgraded Electron 12.0.0-beta.14 that does not have the video recording bug.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 16, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 16, 2021



Test summary

18221 0 214 7Flakiness 6


Run details

Project cypress
Status Passed
Commit 0b850be
Started Jul 16, 2021 6:08 PM
Ended Jul 16, 2021 6:20 PM
Duration 11:07 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
2 ... > automatically parses application/json response bodies
3 network stubbing > intercepting response > does not overwrite the json-related content-type header
4 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review July 16, 2021 18:21
@flotwig flotwig requested a review from a team as a code owner July 16, 2021 18:21
@flotwig flotwig requested review from jennifer-shehane and kuceb and removed request for a team July 16, 2021 18:21
@flotwig flotwig merged commit 789c405 into develop Jul 16, 2021
elevatebart pushed a commit that referenced this pull request Jul 17, 2021
@flotwig flotwig deleted the revert-electron-13 branch January 24, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants