-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address performance issues with video recording in Chrome 89+/Electron 12+ #16152
Labels
type: performance 🏃♀️
Performance related
type: regression
A bug that didn't appear until a specific Cy version release
v7.0.0 🐛
Issue present since 7.0.0
Comments
This was referenced Apr 26, 2021
This was referenced Jul 8, 2021
5 tasks
1 task
The code for this is done in cypress-io/cypress#17408, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: performance 🏃♀️
Performance related
type: regression
A bug that didn't appear until a specific Cy version release
v7.0.0 🐛
Issue present since 7.0.0
Current behavior
We cannot upgrade to Electron 12 because of a major slowdown when video recording is enabled. We are stuck on 12.0.0-beta.14, the last version before the issue appeared.
The issue appears to be related to the Chrome 89 upgrade that occurred in 12.0.0-beta.16. Similar slowdowns occur when video recording in Cypress with Chrome 89, regardless of Electron version.
With some changes released after Chromium 89.0.4328.0 and before/at 89.0.4336.0, capturing screencasts via CDP is now causing performance issues. It seems like our CDP client is receiving many, many more frames before, to the point where the user's CPU is saturated with transmitting/encoding video frames, especially when users run in resource-constrained machines in CI.
The issue can be reproduced by changing the Chrome version as well, independently of Electron's CDP.
Desired behavior
Slowdown is isolated and fixed so that we can continue to ship the latest Electron version.
Relevant:
The text was updated successfully, but these errors were encountered: