chore: fix flaky e2e record passes test #16043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Could you describe how this is reducing the flakiness? |
chrisbreiding
approved these changes
Apr 19, 2021
tgriesser
added a commit
that referenced
this pull request
Apr 19, 2021
* develop: fix flaky e2e record passes test (#16043) chore: switch lolex to new name @sinonjs/fake-timers (#15595) add pwa example (#15970) fix starting cdp screencast when video:false (#15985) fix(deps): update dependency ansi_up to version 5.x 🌟 (#15440) fix: run-ct does not hang on windows anymore (#16022) docs: in vite-dev-server example don't require the config (#15866)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should help reduce variable failures for e2e_record_spec
for e2e record spec we assert on the order of requests to the stubbed out server. we needed a larger delay in the response handler of put/screenshots since theres a race condition in the order of put/screenshots and put/video. The video request is made first so we delay the screenshot request to make sure there's a consistent order to the requests