chore: switch lolex to new name @sinonjs/fake-timers #15595
Conversation
|
Thanks for taking the time to open a PR!
|
packages/driver/src/cypress.js
Outdated
| @@ -649,7 +649,7 @@ $Cypress.prototype.Blob = blobUtil | |||
| $Cypress.prototype.Promise = Promise | |||
| $Cypress.prototype.minimatch = minimatch | |||
| $Cypress.prototype.sinon = sinon | |||
| $Cypress.prototype.lolex = lolex | |||
| $Cypress.prototype.fakeTimers = fakeTimers | |||
There was a problem hiding this comment.
This is where I was a bit in doubt. Should I either keep this as lolex, or do we need to document this change somehow as the comment says its used for monkeypatching?
There was a problem hiding this comment.
Let's keep it as lolex for now, especially since its API is the same. I don't think that it's documented, only a few of the prototype utilities are (see the sidebar under Utilities), so it might not technically be breaking to change it. But I'd rather err on the safe side and we'll consider changing it with the next major release.
There was a problem hiding this comment.
Okay, I'm good with that!
|
I'm a little confused. The only changes I see in this PR are updating the lodash types. Is there something missing regarding the lolex to fake-timers change? |
|
Ohh whoops, that's why you create branches even in your forks. I overwrote this with another PR (that I later made in a new branch though) because I assumed this had already been landed, I'll try changing it back now |
|
There we go! Thank god for git reflog :) |
|
Hi again @chrisbreiding ! There was indeed some errors! I had just run the unit tests locally, which I guess don't cover this part of the code very well as that's maybe more covered in the Cypress tests that were rightly failing. It seems to all track down to one line in the configuration, which was anyways re-specifying window that had just been passed in to withGlobal, so makes sense that it's deprecated if one could do it in two places before. The two test failures I see now, npm-react and npm-vue don't seem to have anything to do with this code, and also rely on waiting in real-time it seems so could it maybe be they are flaky? Or does it have something to do with my missing credentials as I'm pulling in from a fork? Don't think this is related to my code, though I'm happy to work on it with some guidance if it is. I'll also just push another small commit removing a vscode setting disabling formatting I added, so maybe that force of rerunning tests will fix it if they are indeed flaky. And also I put back the monkey patching name to |
|
Awesome! Thank you Chris! |
* develop: fix flaky e2e record passes test (#16043) chore: switch lolex to new name @sinonjs/fake-timers (#15595) add pwa example (#15970) fix starting cdp screencast when video:false (#15985) fix(deps): update dependency ansi_up to version 5.x 🌟 (#15440) fix: run-ct does not hang on windows anymore (#16022) docs: in vite-dev-server example don't require the config (#15866)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Change lolex to new non-deprecated name @sinonjs/fake-timers
Additional details
I was a bit in doubt about the $Cypress.prototype update, do we need to do some documentation changes etc. or make this a breaking change when changing that from lolex to fakeTimers in case someone depends on it?? Input welcome! We could of course also just keep that name lolex
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?