#712: Catch exception on rolling_archive. #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arjclark - looks good, although the problem of #712 was rolling archive use with state dumps, fixed by Matt in #825. Now rolling archive is only used with suite out and err files (which might cause the same problem I guess) ... we should probably treat them similarly to state dumps with atomic symlinking instead of renaming once written. |
hjoliver
added a commit
that referenced
this pull request
Dec 29, 2013
#712: Catch exception on rolling_archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #712.
This should correctly catch the OSError raised when a user runs out of quota.
@hjoliver - please review.