Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle suite out and err files like state dumps? #846

Closed
hjoliver opened this issue Jan 9, 2014 · 6 comments
Closed

Handle suite out and err files like state dumps? #846

hjoliver opened this issue Jan 9, 2014 · 6 comments
Assignees
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jan 9, 2014

ref #828 (comment)

@hjoliver
Copy link
Member Author

hjoliver commented Jun 19, 2016

[meeting] @oliver-sanders to investigate

@oliver-sanders
Copy link
Member

A couple of quick questions to gauge opinion on. @cylc/core

  1. Should we include the log file in with this, it would be nice to have all error files written out in the same way?
  2. This could be achieved nicely if out and err were written through pythons logging module (would make Suite log, out, err rotation should be synchronized #1446 nice and simple and rationalize use of suite stdout, stderr, and the log #386 easier), how do we feel about this?

@hjoliver
Copy link
Member Author

@oliver-sanders - are you suggesting using a single log file for all, or connecting stdout and stderr to different files handled by the logging module? (in the latter case, can the roll-over of multiple logs be synchronised?). I'm open to any suggestions as the current situation isn't very clean. However, @matthewrmshin seems to strongly dislike the Python logging module??

@oliver-sanders
Copy link
Member

@hjoliver I was suggesting writing stdout and stderr messages through the logging module to their respective files (not merging them into one). If it was done like this synchronisation should be relatively straight forward to implement by extending the functionality of the logging module.

@hjoliver
Copy link
Member Author

OK, sounds fine to me if others agree.

@matthewrmshin
Copy link
Contributor

The logging module is appropriate for logging suite activity.

(I do have a dislike of it, because it is too flexible for the things we don't normally need, but incredibly rigid for the things we want to be flexible.)

@matthewrmshin matthewrmshin modified the milestones: next release, soon Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants