Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli dead ends #4144

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Cli dead ends #4144

merged 3 commits into from
Mar 24, 2021

Conversation

oliver-sanders
Copy link
Member

Sorry, missed this in the review of #4099

List the old config commands in the "dead ends" to help train users to the new command names.

Beta zero if we can, however, since the alias get-config -> config covers most use cases it's not that critical.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added this to the cylc-8.0b0 milestone Mar 24, 2021
@oliver-sanders oliver-sanders self-assigned this Mar 24, 2021
@hjoliver
Copy link
Member

I pushed a small fix to this branch. After that, one functional test batch failed, but the failure was in uploading coverage, not in the tests.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One review will do 👍

@hjoliver hjoliver merged commit b30ae33 into cylc:master Mar 24, 2021
@oliver-sanders oliver-sanders deleted the cli-dead-ends branch March 24, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants