Unify get-config

[MetRonnie]

These changes close #4009

• Unify the get-suite-config and get-site-config commands as config
• Remove --python option
• Remove --mark-up option
• Remove --run-mode option
• Remove --suite-owner option
• Remove --tasks and --all-tasks options
• Remove --print-run-dir option
• Add --print-hierarchy option

Requirements check-list

• Probably a good idea to wait for cylc pause #4076 to be merged first
• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Appropriate tests are included (unit and/or functional).
• Already covered by existing tests.
• Appropriate change log entry included.
• (master branch) I have opened a documentation PR at Unify get-config cylc-doc#223.
• No dependency changes.

[oliver-sanders]

Great, can't wait to have this on master.

[oliver-sanders]

I think it's just the default kwarg value that is messing with pytest, could do this:

Suggested change

	# Note: default handle=sys.stdout, but explicitly setting this interferes
	# with pytest capsys:
	# https://github.com/pytest-dev/pytest/issues/1132#issuecomment-147506107
	if not handle:
	handle = sys.stdout

[MetRonnie]

Unfortunately not, in the issue linked in the comment, it says that redefinition of sys.stdout is the problem

[oliver-sanders]

This works for me:

import sys


def whatever(handle=None):
    if not handle:
        handle = sys.stdout
    handle.write('hello world')


def test_whatever(capsys):
    whatever()
    assert capsys.readouterr().out == 'hello world'

[MetRonnie]

Oh, the same test fails for a different reason in that case. The capsys replacement for sys.stdout is not an instance of StringIO, but doesn't have an attribute .mode, which causes an exception at this point

cylc-flow/cylc/flow/parsec/util.py

Lines 142 to 143 in 4b5e8a9

	if not isinstance(handle, StringIO) and 'b' in handle.mode:
	msg = msg.encode()

Could instead do?

if hasattr(handle, 'mode') and 'b' in handle.mode:
    msg = msg.encode()

[MetRonnie]

Note: if this doesn't get merged in time for 8.0b0, will need to edit the changelog

[kinow]

Looks good to me 👍

[oliver-sanders]

Great.