Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings and minor fixes server #3082

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Docstrings and minor fixes server #3082

merged 4 commits into from
Apr 9, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Apr 6, 2019 •
edited by hjoliver
Loading

Fix #3079

  • Adds docstrings fixing warnings that appeared in the IDE.
  • Fixes a few typos
  • Defines the instance context in the constructor

@kinow kinow added the small label Apr 6, 2019
@kinow kinow added this to the cylc-8.0a1 milestone Apr 6, 2019
@kinow kinow self-assigned this Apr 6, 2019
@kinow kinow force-pushed the docstrings-and-minor-fixes-server branch from edc7c78 to e6bf97f Compare April 6, 2019 07:33
@hjoliver hjoliver requested a review from oliver-sanders April 6, 2019 23:49
@kinow kinow force-pushed the docstrings-and-minor-fixes-server branch from e6bf97f to 4eeb04d Compare April 8, 2019 21:43
oliver-sanders
oliver-sanders reviewed Apr 9, 2019
View reviewed changes
lib/cylc/network/server.py

Args:
min_port (int): minimum socket port number
max_port (int): maximum socket port number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: we should make the site configuration more compatible with this, doing min(ports), max(ports) is wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puted to #2978

@oliver-sanders oliver-sanders mentioned this pull request Apr 9, 2019
Closed
8 tasks
@oliver-sanders oliver-sanders merged commit e10af94 into cylc:master Apr 9, 2019
@kinow kinow mentioned this pull request May 15, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@kinow kinow

Labels
small
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging this pull request may close these issues.

Outdated docstrings for cylc.network.server.ZMQServer
3 participants
@kinow @hjoliver @oliver-sanders