Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated docstrings for cylc.network.server.ZMQServer #3079

Closed
kinow opened this issue Apr 5, 2019 · 0 comments · Fixed by #3082
Closed

Outdated docstrings for cylc.network.server.ZMQServer #3079

kinow opened this issue Apr 5, 2019 · 0 comments · Fixed by #3082
Assignees
@kinow
Labels
small
Milestone
cylc-8.0a1

Comments

@kinow
Copy link
Member

kinow commented Apr 5, 2019

Going out soon and may not have time to prepare a pull request, but a low hanging fruit and happy if anyone beats me to it :-)

cylc.network.server.py has a few outdated docstrings (e.g. start() is still mentioning ports that was previously used, but now is using min_port and max_port).

Found while working on #3077 as the IDE raised a few new issues 👍

Cheers
Bruno
@kinow kinow added the small label Apr 5, 2019
@kinow kinow added this to the cylc-8.0a1 milestone Apr 5, 2019
@kinow kinow changed the title Fix docstrings for cylc.network.server.ZMQServer Outdated docstrings for cylc.network.server.ZMQServer Apr 5, 2019
@kinow kinow mentioned this issue Apr 6, 2019
Merged
@kinow kinow self-assigned this Apr 6, 2019
@kinow kinow mentioned this issue May 15, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinow kinow

Labels
small
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging a pull request may close this issue.

Docstrings and minor fixes server kinow/cylc-flow
1 participant
@kinow