Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan: don't force host/owner vis #2819

Merged

Conversation

matthewrmshin
Copy link
Contributor

@matthewrmshin matthewrmshin commented Oct 26, 2018

Don't force host/owner visibility in multi-host/owner modes. (Ref #2096.)

@matthewrmshin matthewrmshin added this to the next release milestone Oct 26, 2018
@matthewrmshin matthewrmshin self-assigned this Oct 26, 2018
@oliver-sanders
Copy link
Member

Isn't the new behaviour that the host column is ONLY visible if hosts are provided as command line arguments?

@matthewrmshin
Copy link
Contributor Author

matthewrmshin commented Oct 26, 2018

No, you can turn it on/off if you want. The new behaviour here stops it from making the host column visible automatically after each update. (Users are unable to turn it off before this change - if they have suites running on multiple hosts).

@hjoliver
Copy link
Member

@matthewrmshin - I'm slightly confused. Contrary to your previous comment, testing conforms to your description and title which implies "host" column can't be turned off if I request a multi-host scan on the command line (cylc gscan hostA hostB). It can now be tuned off if I did not request a multi-host scan, which is an improvement on master - but shouldn't I be able to turn the host column off even if I did request a multi-host scan? (maybe I am using multiple suite hosts but am not interested in which suite is running on which host).

@matthewrmshin
Copy link
Contributor Author

@hjoliver It can be done by simply removing the block that forces the host column to be visible. Is this what we want?

@hjoliver
Copy link
Member

Yes, I think so.

@oliver-sanders
Copy link
Member

Wouldn't the simplest option be to treat the host column like the others? Only display it if the user wants it displayed irrespective of how gscan was launched.

Don't force visible host/owner columns in multi-host/owner scans.
@matthewrmshin matthewrmshin force-pushed the cylc-gscan-tweak-host-col-visibility branch from 7814dc7 to 0f502a8 Compare October 29, 2018 11:06
@matthewrmshin
Copy link
Contributor Author

Done for both host and owner.

@matthewrmshin matthewrmshin changed the title gscan: host col always vis only for >1 hosts opt gscan: don't force host/owner vis Oct 29, 2018
@hjoliver
Copy link
Member

Yes, I agree with @oliver-sanders - that's what I meant in fact.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@hjoliver hjoliver merged commit 2c73a54 into cylc:master Oct 29, 2018
@matthewrmshin matthewrmshin deleted the cylc-gscan-tweak-host-col-visibility branch October 29, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants