-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gscan: don't force host/owner vis #2819
gscan: don't force host/owner vis #2819
Conversation
Isn't the new behaviour that the host column is ONLY visible if hosts are provided as command line arguments? |
No, you can turn it on/off if you want. The new behaviour here stops it from making the host column visible automatically after each update. (Users are unable to turn it off before this change - if they have suites running on multiple hosts). |
@matthewrmshin - I'm slightly confused. Contrary to your previous comment, testing conforms to your description and title which implies "host" column can't be turned off if I request a multi-host scan on the command line ( |
@hjoliver It can be done by simply removing the block that forces the host column to be visible. Is this what we want? |
Yes, I think so. |
Wouldn't the simplest option be to treat the host column like the others? Only display it if the user wants it displayed irrespective of how |
Don't force visible host/owner columns in multi-host/owner scans.
7814dc7
to
0f502a8
Compare
Done for both host and owner. |
Yes, I agree with @oliver-sanders - that's what I meant in fact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Don't force host/owner visibility in multi-host/owner modes. (Ref #2096.)