gscan: new -a and -o OWNER-PATTERN options #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98eb821 to
3c13d4f
Compare
oliver-sanders
requested changes
Jan 5, 2017
There was a problem hiding this comment.
The code looks fine, unfortunately I've found a few bugs:
- The groups feature is broken
- User defined default columns feature is broken
- Launching gcylc works via the right-click menu but not on double click
- If a host is removed (via the right click menu) any suites running on that host show as stopped (rather than disappearing as they did before)
- gpanel would appear to be running in
-o .*mode! - Changing hosts (via the right click menu) isn't working as expected for me
|
@oliver-sanders reported issues should now be fixed. |
|
@matthewrmshin Bugs tested as fixed. Just a couple of small niggles left:
|
Can now filter by suite owners. Display host column by default, if scanning multiple hosts. New owner column, display by default if scanning other users. Refactor: * Results dict key now a tuple of (host, owner, suite) - as multiple users can run suites with the same names on the same hosts. * Reduce unnecessary logic and caching of previous results. * Can now use the data structure returned by port scan without fiddling. * Use `cylc ls-checkpoint` instead of `cylc cat-state` to get info for a stopped suite. * Moved shared functions between `cylc.gui.gpanel` and `cylc.gui.gscan` to a separate module `cylc.gui.scanutil`.
|
@oliver-sanders reported small niggles should now be fixed. |
hjoliver
reviewed
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now filter by suite owners.
Display host column by default, if scanning multiple hosts.
New owner column, display by default if scanning other users.
Refactor:
users can run suites with the same names on the same hosts.
cylc ls-checkpointinstead ofcylc cat-stateto get info fora stopped suite.
cylc.gui.gpanelandcylc.gui.gscanto a separate module
cylc.gui.scanutil.Close #1625.