Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan: catch potential ZeroDivisionError #2156

Merged
merged 1 commit into from
Feb 10, 2017
Merged

gscan: catch potential ZeroDivisionError #2156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/cylc/gui/gscan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def _on_button_press_event(self, treeview, event):
treemodel = treeview.get_model()

# Dismiss warnings by clicking on a warning icon.
if (event.button == 1):
if event.button == 1:
if not pth:
return False
path, column, cell_x, _ = pth
Expand All @@ -225,7 +225,10 @@ def _on_button_press_event(self, treeview, event):
column.get_cell_renderers()[1]))
if not dot_width:
return False
cell_index = (cell_x - dot_offset) // dot_width
try:
cell_index = (cell_x - dot_offset) // dot_width
except ZeroDivisionError:
return False
if cell_index == 0:

iter_ = treemodel.get_iter(path)
Expand Down