Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan: catch potential ZeroDivisionError #2156

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

matthewrmshin
Copy link
Contributor

A user reported this:

Suppose someone decided to open cylc gscan,
and then played around with the size of the window and perhaps did some too
drastic changes resulting in error messages something like

   cell_index = ((cell_x - dot_offset) // dot_width) + 1
ZeroDivisionError: integer division or modulo by zero

@matthewrmshin matthewrmshin added the bug Something is wrong :( label Feb 10, 2017
@matthewrmshin matthewrmshin added this to the next release milestone Feb 10, 2017
@matthewrmshin
Copy link
Contributor Author

@oliver-sanders please feel free to assign a 2nd reviewer.

@oliver-sanders
Copy link
Member

oliver-sanders commented Feb 10, 2017

See also #2029

@oliver-sanders oliver-sanders merged commit 7041d8c into cylc:master Feb 10, 2017
@matthewrmshin matthewrmshin deleted the gscan-catch-zero-division branch February 10, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants