Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1043 warm start follow up #1056

Merged

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Aug 5, 2014

This follows on from #1043, for #119. It [now!] just attempts to more clearly document the difference between cold and warm start, and the sole reason for using old-style cold-start tasks.

@hjoliver hjoliver added this to the cylc-6 milestone Aug 5, 2014
@hjoliver
Copy link
Member Author

hjoliver commented Aug 5, 2014

@benfitzpatrick - please review.

@hjoliver
Copy link
Member Author

hjoliver commented Aug 5, 2014

Ben - this is ready for review now. I temporarily forgot how my own b4stard child, the "cold-start task" worked - they do still need to be loaded as 'succeeded' in a warm start as you must have realised. So with this back on my mind I attempted to document more clearly the difference between cold start, warm start, and restart; and when (if ever) to use old-style cold-start tasks ... which had never really been done properly in the user guide.

@hjoliver
Copy link
Member Author

hjoliver commented Aug 5, 2014

(hang on ... maybe not ready - some tests are failing; groan).

@hjoliver
Copy link
Member Author

hjoliver commented Aug 5, 2014

I think it's ok, the failing tests are all the new graphing ones under tests/cyclers/ due to a default colour being lightgrey rather than black on my box.

@benfitzpatrick
Copy link
Contributor

Looks good - I think we're getting closer to the big 6!

benfitzpatrick added a commit that referenced this pull request Aug 5, 2014
@benfitzpatrick benfitzpatrick merged commit 4b37971 into cylc:119.iso8601-cycling Aug 5, 2014
@hjoliver hjoliver deleted the 1043-warm-start-follow-up branch August 5, 2014 21:50
hjoliver added a commit to hjoliver/cylc-flow that referenced this pull request Aug 6, 2014
@hjoliver hjoliver mentioned this pull request Aug 6, 2014
hjoliver added a commit to hjoliver/cylc-flow that referenced this pull request Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants