Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#119: warm start support #1043

Merged

Conversation

benfitzpatrick
Copy link
Contributor

This adds proper warm start support back for #119.

This is done by decoupling the "prerequisite-start" point ("start_point") from
the "sequence-start" point ("initial_point" or "initial cycle point").

"final_point" now means the "final cycle point", while "stop_point" is
a configured stop point e.g. via cylc stop.

@hjoliver, please review.

@benfitzpatrick benfitzpatrick added this to the cylc-6 milestone Jul 30, 2014
@hjoliver
Copy link
Member

hjoliver commented Aug 1, 2014

@benfitzpatrick - looks good, but:

Your third commit restored the bin/cylc-run:load_tasks_warm() method, but I think we can get rid of that now, and replace it with simply ignoring declared cold-start tasks at warm start-up (even that's only needed for back-compat because new cold-start tasks should be in an R1 which will be out of bounds in a warm start, right?). Loading declared cold-start tasks in the succeeded state is definitely no longer necessary now that pre start point triggers are ignored. The only other difference between the current cold and warm load_tasks methods is use of the startup flag passed to task proxy class init, and in fact that should be True for warm and cold start - the flag is only used to trigger adjustment of the suite start point up to the next valid point for the task, and that should happen for warm start too. Currently it doesn't: e.g. for [[[T00]]] foo if you warmstart at 12Z the first instance of foo will be - wrongly - at 12Z. Then, while you're at it you might as well get rid of the old raw start method.

@hjoliver
Copy link
Member

hjoliver commented Aug 4, 2014

Ben - your branch needs an update. My suggested changes, if you agree, should be pretty trivial ... then we might be able to merge the #119 feature branch to master at last 😃

hjoliver added a commit that referenced this pull request Aug 5, 2014
@hjoliver hjoliver merged commit 3e6e337 into cylc:119.iso8601-cycling Aug 5, 2014
@benfitzpatrick benfitzpatrick deleted the warm-start.pre-initial branch October 15, 2014 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants