Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nuclio version and fix issues from the outdated version #6610

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

MuhammadSYahyaS
Copy link
Contributor

Motivation and context

Issue #6183 still exists in CVAT v2.5.2. Following up the addressed issue nuclio/nuclio#2938 in the nuclio community, they suggested to use new nuclio version (1.11.x). It seems that the templates fetching mechanism on the old nuclio versions is not supported anymore, causing the mentioned issue.

How has this been tested?

Following the Semi-automatic and Automatic Annotation guideline on the CVAT v2.5.2 release branch (for the sake of stability) in a RHEL 8 machine, but changed the nuclio version to 1.11.24 and disabling the /tmp mounting to the nuclio container. Additionally, removed the unused static IP address value in the no_proxy environment. Tested using SAM model with GPU following that guideline on some random images from a remote client.

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #6610 (cfe3b02) into develop (948db75) will decrease coverage by 0.06%.
Report is 6 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6610      +/-   ##
===========================================
- Coverage    82.50%   82.45%   -0.06%     
===========================================
  Files          366      366              
  Lines        39810    39810              
  Branches      3538     3538              
===========================================
- Hits         32846    32826      -20     
- Misses        6964     6984      +20     
Components Coverage Δ
cvat-ui 77.45% <ø> (-0.10%) ⬇️
cvat-server 86.82% <100.00%> (-0.01%) ⬇️

@nmanovic
Copy link
Contributor

@MuhammadSYahyaS , thanks for the contribution!

@nmanovic nmanovic merged commit 40f2472 into cvat-ai:develop Aug 24, 2023
jonybekov pushed a commit to tezzro/cvat that referenced this pull request Sep 6, 2023
…#6610)

Issue cvat-ai#6183 still exists in CVAT
v2.5.2. Following up the addressed issue
nuclio/nuclio#2938 in the [nuclio
community](https://github.com/nuclio/nuclio), they suggested to use new
nuclio version (1.11.x). It seems that the templates fetching mechanism
on the old nuclio versions is not supported anymore, causing the
mentioned issue.


### How has this been tested?
Following the [Semi-automatic and Automatic
Annotation](https://opencv.github.io/cvat/docs/administration/advanced/installation_automatic_annotation/)
guideline on the CVAT v2.5.2 release branch (for the sake of stability)
in a RHEL 8 machine, but changed the nuclio version to 1.11.24 and
disabling the `/tmp` mounting to the nuclio container. Additionally,
removed the unused static IP address value in the `no_proxy`
environment. Tested using [SAM
model](https://www.cvat.ai/post/facebook-segment-anything-model-in-cvat)
with GPU following that guideline on some random images from a remote
client.
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
…#6610)

Issue cvat-ai#6183 still exists in CVAT
v2.5.2. Following up the addressed issue
nuclio/nuclio#2938 in the [nuclio
community](https://github.com/nuclio/nuclio), they suggested to use new
nuclio version (1.11.x). It seems that the templates fetching mechanism
on the old nuclio versions is not supported anymore, causing the
mentioned issue.


### How has this been tested?
Following the [Semi-automatic and Automatic
Annotation](https://opencv.github.io/cvat/docs/administration/advanced/installation_automatic_annotation/)
guideline on the CVAT v2.5.2 release branch (for the sake of stability)
in a RHEL 8 machine, but changed the nuclio version to 1.11.24 and
disabling the `/tmp` mounting to the nuclio container. Additionally,
removed the unused static IP address value in the `no_proxy`
environment. Tested using [SAM
model](https://www.cvat.ai/post/facebook-segment-anything-model-in-cvat)
with GPU following that guideline on some random images from a remote
client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants