Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blank-card has a border #652

Closed
harristom opened this issue Jan 20, 2023 · 5 comments
Closed

blank-card has a border #652

harristom opened this issue Jan 20, 2023 · 5 comments
Labels
bug Something isn't working released on @beta released

Comments

@harristom
Copy link

harristom commented Jan 20, 2023 •
edited
Loading

Checklist

  • [x ] I updated the card to the latest version available
  • [x ] I cleared the cache of my browser

Describe the bug
Setting color type to blank-card creates a visible card (specifically, I think it is the border that is visible)

Version of the card
Version: v3.4.2

To Reproduce
This is the configuration I used:

type: custom:button-card
color_type: blank-card

Screenshots
image

Expected behavior
No card should be visible

Desktop (please complete the following information):

  • Browser: Edge
  • Version 109.0.1518.55 (Official build) (64-bit)

Additional context
None
@harristom harristom added the bug Something isn't working label Jan 20, 2023
@rbisschops
Copy link

Also see this behavior in Windows10 - Chrome Version 109.0.5414.121 (Official build) (64-bits); iOS - Chrome version 110.0.5481.83

@alanthewild
Copy link

Seeing the same behaviour in:

  • MacOS Ventura 13.1, Chrome version 109.0.5414.119 (Official Build) (arm64)
  • MacOS Ventura 13.1, Safari version 16.2 (18614.3.7.1.5)
  • iPhone 13 - iOS 16.2, Chrome version 110.0.5481.83

Issue is NOT present in Home Assistant 2022.7.7, Frontend 20220707.1 - latest
Issue is present in Home Assistant 2022.12.8, Frontend 20221213.1 - latest
Issue is present in Home Assistant 2023.2.5, Frontend 20230202.0 - latest
All using same button-card v3.4.2

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Feb 21, 2023 •
edited
Loading

all cards have that since a recent HA frontend change. This is not a button-card bug, it is core HA behavior

set ha-card-border-width: 0px in your theme and it is gone.

or add that to a specific button-card, if you don't want to change the overall look in the Dashboard

github-actions bot pushed a commit that referenced this issue Apr 2, 2023
@semantic-release-bot
chore(release): 3.5.0-dev.2 [skip ci]
56000aa 
## [3.5.0-dev.2](v3.5.0-dev.1...v3.5.0-dev.2) (2023-04-02)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [#669](#669) [#671](#671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [#672](#672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [#652](#652)

### Documentation

* minor quotes correction ([#437](#437)) ([9b5f728](9b5f728))
* minor quotes correction ([#438](#438)) ([07ae7a1](07ae7a1))
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

🎉 This issue has been resolved in version 3.5.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Apr 2, 2023
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
3d8c382 
## [3.5.0](v3.4.2...v3.5.0) (2023-04-02)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [#426](#426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [#669](#669) [#671](#671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [#672](#672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [#652](#652)

### Documentation

* minor quotes correction ([#437](#437)) ([9b5f728](9b5f728))
* minor quotes correction ([#438](#438)) ([07ae7a1](07ae7a1))
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
79ec787 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
2196a71 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
33cff9e 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
cf8835a 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @beta released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rbisschops @alanthewild @Mariusthvdb @harristom