Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support action fire-dom-event #429

Closed
domoson opened this issue Feb 11, 2021 · 15 comments
Closed

Support action fire-dom-event #429

domoson opened this issue Feb 11, 2021 · 15 comments
Labels
FR Feature Request released

Comments

@domoson
Copy link

domoson commented Feb 11, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
browser_mod switching to fire-dom-event away from call-service for popups, toasts, etc., see release notes: https://github.com/thomasloven/hass-browser_mod/releases/tag/1.3.0

Describe the solution you'd like
Implement support for action: fire-dom-event in tap_action and hold_action

Describe alternatives you've considered
As of now browser_mod can still be used with call-service action, but might be phased out soon

Additional context
Thank you :-)
@domoson domoson added the FR Feature Request label Feb 11, 2021
@RomRider
Copy link
Collaborator

RomRider commented Feb 11, 2021 •
edited
Loading

Thanks, it's already planned, I'm just waiting on this PR to be merged and released: custom-cards/custom-card-helpers#29 ;)

@domoson
Copy link
Author

domoson commented Feb 11, 2021

Oh wow, awesome, thanks :-)

This was referenced Feb 13, 2021
Closed
Closed
@VDRainer
Copy link

@domoson , i copied your post to other custom-cards. Hope that's OK?

@domoson
Copy link
Author

domoson commented Feb 14, 2021

@VDRainer yeah sure! Thank you

@VDRainer VDRainer mentioned this issue Feb 14, 2021
Closed
This was referenced Feb 16, 2021
Closed
Closed
@anubisg1
Copy link

any idea when this will be merged? my UI is totally broken right now

@domoson
Copy link
Author

domoson commented Feb 16, 2021

any idea when this will be merged? my UI is totally broken right now

You can still use the service call.

@marcodb82
Copy link

Is your feature request related to a problem? Please describe.
browser_mod switching to fire-dom-event away from call-service for popups, toasts, etc., see release notes: https://github.com/thomasloven/hass-browser_mod/releases/tag/1.3.0

Describe the solution you'd like
Implement support for action: fire-dom-event in tap_action and hold_action

Describe alternatives you've considered
As of now browser_mod can still be used with call-service action, but might be phased out soon

Additional context
Thank you :-)

any idea when this will be merged? my UI is totally broken right now

You can still use the service call.

I have the same problem actually i used

tap_action: action: call-service service: browser_mod.popup

in every 'custom:button-card' tap_action
but after update browser_mod to new 1.3.0 nothing happens (all is broken)

Can you explain please what means: " You can still use the service call."?

tks

@RomRider
Copy link
Collaborator

PR has been merged, I'll release something in the evening.

@marcodb82
Copy link

PR has been merged, I'll release something in the evening.

Exuse if i'm newbie. What means PR? .... project ?
tks

@anubisg1
Copy link

PR has been merged, I'll release something in the evening.

Exuse if i'm newbie. What means PR? .... project ?
tks

means "pull request" , it means that the changes are being accepted in the main code

@domoson
Copy link
Author

domoson commented Feb 17, 2021

I have the same problem actually i used

tap_action: action: call-service service: browser_mod.popup

in every 'custom:button-card' tap_action
but after update browser_mod to new 1.3.0 nothing happens (all is broken)

Can you explain please what means: " You can still use the service call."?

tks

Did it work before? Can you post a full example with proper formatting? One thing that comes to mind is that deviceID: this is no longer supported. Have you tried removing it?

If nothing helps I suggest let's just wait for the new release tonight ;-) Thanks @RomRider !

github-actions bot pushed a commit that referenced this issue Feb 17, 2021
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
4a029c7 
## 1.0.0 (2021-02-17)

### Bug Fixes

* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [#429](#429)

### Documentation

* Override location of lock ([#336](#336)) ([432c038](432c038)), closes [#335](#335)
github-actions bot pushed a commit that referenced this issue Feb 17, 2021
@semantic-release-bot
chore(release): 3.4.2 [skip ci]
75375e7 
### [3.4.2](v3.4.1...v3.4.2) (2021-02-17)

### Bug Fixes

* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [#429](#429)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@drivin drivin mentioned this issue Feb 18, 2021
Closed
@marcodb82
Copy link

Hy, I update to last release. With Chrome and and WALLPANEL the tap_action with browser_mod for opening a POPUP now work.

Instead it doesn't work with official HA APP and also with Fullykiosk. When a tap on the button nothing happen. Someone can help.

@RomRider
Copy link
Collaborator

You're probably not running the latest version of either button-card or browser_mod because it's in cache. So clear the cache.

@marcodb82
Copy link

You're probably not running the latest version of either button-card or browser_mod because it's in cache. So clear the cache.

Thank. Now Work.

@FreekingDean FreekingDean mentioned this issue Mar 19, 2022
Closed
@e2m32 e2m32 mentioned this issue Oct 17, 2022
Closed
@breti breti mentioned this issue Dec 30, 2022
Open
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
79ec787 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
2196a71 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
33cff9e 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
github-actions bot pushed a commit to Dehumanizer77/button-card that referenced this issue Jun 23, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
cf8835a 
## 1.0.0 (2023-06-23)

### Features

* **state_display:** Support for `state_display` in `state` ([440dc77](440dc77)), closes [custom-cards#426](https://github.com/Dehumanizer77/button-card/issues/426)

### Bug Fixes

* card broken with HA 2023.04bXX ([9b4f1e2](9b4f1e2)), closes [custom-cards#669](https://github.com/Dehumanizer77/button-card/issues/669) [custom-cards#671](https://github.com/Dehumanizer77/button-card/issues/671)
* extra space at bottom because of button-card-action-handler ([699b57d](699b57d)), closes [custom-cards#672](https://github.com/Dehumanizer77/button-card/issues/672)
* remove border from blank card ([b05c6b4](b05c6b4)), closes [custom-cards#652](https://github.com/Dehumanizer77/button-card/issues/652)
* Support for `fire-dom-event` ([f4fcbfe](f4fcbfe)), closes [custom-cards#429](https://github.com/Dehumanizer77/button-card/issues/429)

### Documentation

* minor quotes correction ([custom-cards#437](https://github.com/Dehumanizer77/button-card/issues/437)) ([9b5f728](9b5f728))
* minor quotes correction ([custom-cards#438](https://github.com/Dehumanizer77/button-card/issues/438)) ([07ae7a1](07ae7a1))
* Override location of lock ([custom-cards#336](https://github.com/Dehumanizer77/button-card/issues/336)) ([432c038](432c038)), closes [custom-cards#335](https://github.com/Dehumanizer77/button-card/issues/335)
@irakhlin irakhlin mentioned this issue Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FR Feature Request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@anubisg1 @RomRider @domoson @VDRainer @marcodb82