fix(Menu): Pass onClick through even when rendered as a link #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3219da5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Moskvyak
previously approved these changes
Jul 18, 2024
d3dd991 to
5546c7e
Compare
Moskvyak
approved these changes
Jul 18, 2024
mcwinter07
reviewed
Jul 18, 2024
There was a problem hiding this comment.
@dougmacknz I think Cass was saying if we rebase off main and force push to the branch this will (hopefully) pass chromatic. Holler if you want me to give that a crack :)
nvm, commented just as you did 😆 |
mcwinter07
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
No reason to block this, it's needed in some cases where you want to do something before navigating, like tracking. Best to still keep the element as a link in the DOM in this case.
What
Currently,
onClickis not being passed through in the case that MenuItem has anhrefand renders a link