fix(Menu): Pass onClick through even when rendered as a link

cultureamp · Jul 18, 2024 · d3dd991 · d3dd991
1 parent 1167f2d
commit d3dd991
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/lazy-crabs-pay.md b/.changeset/lazy-crabs-pay.md
@@ -0,0 +1,5 @@
+---
+"@kaizen/components": patch
+---
+
+Pass onClick through to MenuItem even when it is rendered as a link
diff --git a/packages/components/src/Menu/subcomponents/MenuItem/MenuItem.tsx b/packages/components/src/Menu/subcomponents/MenuItem/MenuItem.tsx
@@ -7,7 +7,7 @@ export type MenuItemProps = {
   href?: string
   // Only applicable if href is supplied above
   target?: string
-  onClick?: (e: React.MouseEvent<HTMLButtonElement>) => void
+  onClick?: (e: React.MouseEvent<HTMLButtonElement | HTMLAnchorElement>) => void
   icon?: JSX.Element
   destructive?: boolean
   disabled?: boolean
@@ -70,6 +70,7 @@ export const MenuItem = ({
         <a
           id={id}
           href={href}
+          onClick={onClick}
           className={className}
           target={target}
           // this tells screenreaders that this link represents the current page