Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#75]: Update changelog with note about change to fix #76

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

dermetfan
Copy link
Contributor

Issue reference:

In response to #74 (comment).

I hope the wording is okay.

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@dermetfan dermetfan changed the title update changelog with note about breaking change in #74 update changelog with note about breaking change to fix #75 Jul 15, 2024
@kvanbere
Copy link
Member

kvanbere commented Aug 6, 2024

Thank you @dermetfan, sorry for the delay.

@kvanbere
Copy link
Member

kvanbere commented Aug 6, 2024

Would you like to be added to the AUTHORS file?

@kvanbere kvanbere changed the title update changelog with note about breaking change to fix #75 [#75]: Update changelog with note about change to fix Aug 6, 2024
@dermetfan dermetfan deleted the pr-draft branch August 17, 2024 20:09
@dermetfan
Copy link
Contributor Author

Feel free to add me if you think my tiny contribution justifies it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants