Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#75]: Add missing draft field to HookPullRequest #74

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

dermetfan
Copy link
Contributor

Issue reference:

I didn't open an issue as this seemed simple enough.

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?
    • → Is it? I'm very new to Haskell. I suppose it does break instantiations so that they now result in a missing field error.

@kvanbere
Copy link
Member

Thanks @dermetfan . LGTM

Hey @roberth , are you in a position to test if this breaks any of your stuff?

@kvanbere
Copy link
Member

Hm, let me schedule it for testing here and we'll get back to you soon. Sorry about the delay.

@kvanbere kvanbere merged commit 586cd07 into cuedo:develop Jul 15, 2024
@kvanbere kvanbere changed the title add missing draft field to HookPullRequest [#75]: Add missing draft field to HookPullRequest Jul 15, 2024
@kvanbere
Copy link
Member

Looks good to me, sorry that took so long. :)

@kvanbere
Copy link
Member

kvanbere commented Jul 15, 2024

@dermetfan could I ask you to please open a second PR updating the changelog with this change? It is a breaking change (number of fields in record), but we forgot to add it.

@kvanbere kvanbere requested review from kvanbere and removed request for kvanbere July 15, 2024 00:44
@kvanbere kvanbere added the bug label Jul 15, 2024
@kvanbere kvanbere added this to the 0.18.0 milestone Jul 15, 2024
@dermetfan dermetfan deleted the pr-draft branch July 15, 2024 14:09
dermetfan added a commit to dermetfan/github-webhooks that referenced this pull request Jul 15, 2024
dermetfan added a commit to input-output-hk/hydra-tools that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants