Get JavaScript to parity with Java #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # javascript/package-lock.json # javascript/package.json
mpkorstanje
reviewed
Nov 14, 2024
| id: string | number | ||
| } | ||
|
|
||
| export function comparatorById(a: WithId, b: WithId) { |
There was a problem hiding this comment.
I don't see where this is used.
There was a problem hiding this comment.
Ah never mind. Git collapsed the file that used it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This adds new methods to the JavaScript implementation to match the ones recently added for Java.
We're also making a couple of changes on the Java side for the better:
Finally, update the Node.js versions we test with to match the current LTS landscape.
⚡️ What's your motivation?
These methods will help drive the test case-centric reporting needed for the JUnit formatter and the reimagined HTML formatter. These should be powerful for users creating their own message-based formatters too.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.