-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaScript implementation #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some more stuff needed for this to be merge-ready:
|
davidjgoss
commented
Nov 3, 2024
davidjgoss
commented
Nov 3, 2024
mpkorstanje
reviewed
Nov 3, 2024
mpkorstanje
reviewed
Nov 3, 2024
mpkorstanje
reviewed
Nov 3, 2024
mpkorstanje
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only spotted a few difference between JS and Java. If you need help fixing these in Java let me know.
7 tasks
mpkorstanje
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR adds a JavaScript implementation of the formatter which passes the same acceptance tests as the Java one and is built with the new plugin-based cucumber-js formatter structure.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
See inline comments.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.