Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript implementation #42

Merged
merged 30 commits into from
Nov 15, 2024
Merged

Add JavaScript implementation #42

merged 30 commits into from
Nov 15, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 3, 2024

🤔 What's changed?

This PR adds a JavaScript implementation of the formatter which passes the same acceptance tests as the Java one and is built with the new plugin-based cucumber-js formatter structure.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

See inline comments.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss
Copy link
Contributor Author

davidjgoss commented Nov 3, 2024

Some more stuff needed for this to be merge-ready:

  • Add pull request and release actions for CI
  • Add README.md
  • Add option to override suite name for parity with existing cucumber-js formatter
  • Handle scenarios with no steps correctly
  • Address mismatch of retry behaviour with Java

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only spotted a few difference between JS and Java. If you need help fixing these in Java let me know.

@davidjgoss davidjgoss marked this pull request as ready for review November 14, 2024 22:50
@davidjgoss davidjgoss merged commit 9f0b858 into main Nov 15, 2024
8 checks passed
@davidjgoss davidjgoss deleted the feat/javascript branch November 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants